Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proptest arithmetic generics #6263

Open
michaeljklein opened this issue Oct 10, 2024 · 0 comments · May be fixed by #6269
Open

Proptest arithmetic generics #6263

michaeljklein opened this issue Oct 10, 2024 · 0 comments · May be fixed by #6269
Assignees
Labels
enhancement New feature or request

Comments

@michaeljklein
Copy link
Contributor

Problem

Arithmetic generics have gotten more complex recently and we only have a handful of unit tests to check them.

This seems insufficient since we have 5 BinaryTypeOperator's, rules involving pairs of operators, and at least two conditions for simplification (== 0 and divides_evenly). This could result in appx. 5^2 * 2^2 = 100 potentially interesting cases, but we have far fewer than a hundred tests for them.

Happy Case

Property test canonicalize and try_unify_by_moving_constant_terms by:

  • generating a single InfixExpr, canonicalizing it, instantiating all inputs in both terms, and asserting equality of the results
  • generating pairs of InfixExpr's, canonicalizing each, attempting to unify, and if they unify, instantiating all inputs in both terms, and asserting equality of the results

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

Nice-to-have

Blocker Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@michaeljklein michaeljklein added the enhancement New feature or request label Oct 10, 2024
@michaeljklein michaeljklein self-assigned this Oct 10, 2024
@michaeljklein michaeljklein linked a pull request Oct 10, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

1 participant