Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid rayon usage when running in single-threaded mode. #6872

Open
TomAFrench opened this issue Dec 19, 2024 · 2 comments
Open

Avoid rayon usage when running in single-threaded mode. #6872

TomAFrench opened this issue Dec 19, 2024 · 2 comments

Comments

@TomAFrench
Copy link
Member

We currently use rayon unconditionally but we should be able to avoid this entirely if we're running with a single thread.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Dec 19, 2024
@asterite
Copy link
Collaborator

asterite commented Jan 6, 2025

I thought about this, but I think we also increase the stack size of the threads we spawn. So I think we need to always span at least one thread to be able to control its stack size.

@TomAFrench
Copy link
Member Author

I think that's only the case as rayon threads are by default given a smaller stack size compared to the main thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants