Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ECDSA secp256k1 signature verification #11

Open
Savio-Sou opened this issue May 23, 2024 · 0 comments · May be fixed by #13
Open

Add ECDSA secp256k1 signature verification #11

Savio-Sou opened this issue May 23, 2024 · 0 comments · May be fixed by #13
Labels
enhancement New feature or request

Comments

@Savio-Sou
Copy link
Contributor

Circom implementation: https://github.com/0xPARC/circom-ecdsa
Noir implementation: https://noir-lang.org/docs/noir/standard_library/cryptographic_primitives/ecdsa_sig_verification/#ecdsa_secp256k1verify_signature
@Savio-Sou Savio-Sou added the enhancement New feature or request label May 23, 2024
This was referenced May 27, 2024
Merged
Open
github-merge-queue bot pushed a commit to noir-lang/noir that referenced this issue Jul 15, 2024
@guipublic @TomAFrench
chore: add benchmark for ecdsa (#5113)
558d79e 
# Description

## Problem\*

Related to noir-lang/zk_bench#11

## Summary\*
Add a benchmark test for noir ends, following PR 6566 (aztec-packages)


## Additional Context



## Documentation\*

Check one:
- [X] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [X] I have tested the changes locally.
- [X] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Tom French <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add ecdsa test noir-lang/zk_bench
1 participant
@Savio-Sou