Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | NSFS | Organize Modules/Dependencies #8548

Open
shirady opened this issue Nov 20, 2024 · 0 comments
Open

NC | NSFS | Organize Modules/Dependencies #8548

shirady opened this issue Nov 20, 2024 · 0 comments
Assignees
Labels

Comments

@shirady
Copy link
Contributor

shirady commented Nov 20, 2024

Environment info

  • NooBaa Version: current, master
  • Platform: NC

This is the place for organizing the dependencies:

  1. Move the file src/endpoint/s3/s3_bucket_policy_utils.js to src/util (it is used by the noobaa-cli in src/manage_nsfs/manage_nsfs_validations.js).
  2. Move the content of validate_username from src/endpoint/iam/iam_utils.js (it is used by noobaa-cli in src/manage_nsfs/manage_nsfs_validations.js).
  3. Use the function generate_id from file src/nc/nc_utils.js in places that used directly mongo_utils.mongoObjectId() (for example: src/cmd/manage_nsfs.js). I think we can copy the content and add a reference and credit instead of any use of the module src/util/mongo_utils.js in src/nc/nc_utils.js.
@shirady shirady added NS-FS Non Containerized Non containerized labels Nov 20, 2024
@shirady shirady changed the title NC | NSFS | Organize Modules/Dependecies NC | NSFS | Organize Modules/Dependencies Nov 20, 2024
@shirady shirady self-assigned this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant