Added restriction to limit the ID length to 255 characters in bucket lifecycle rules #8628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achouhan09
requested review from
a team and
aspandey
and removed request for
a team
achouhan09
changed the title
|
Hey @achouhan09
|
…lifecycle rules Signed-off-by: Aayush Chouhan <[email protected]>
|
Hi @romayalon Added issue link and tests. Thanks |
Signed-off-by: Aayush Chouhan <[email protected]>
shirady
reviewed
Jan 5, 2025
| @@ -88,7 +88,12 @@ async function put_bucket_lifecycle(req) { | |||
| }; | |||
|
|
|||
| if (rule.ID?.length === 1) { | |||
| current_rule.id = rule.ID[0]; | |||
| if (rule.ID[0].length > 255) { | |||
There was a problem hiding this comment.
I'm suggesting to move the 255 to a const variable for easier reading of the code and maintenance - in case in the future it will be changed we need to change it in one place only, for example:
const MAX_LENGTH_RULE_ID = 255 and reuse it in the error message.
| const putLifecycleParams = id_length_lifecycle_configuration(Bucket, Key); | ||
|
|
||
| await s3.putBucketLifecycleConfiguration(putLifecycleParams) | ||
| .catch(error => { |
There was a problem hiding this comment.
Why do you use a promise chain here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: