Fix for not accepting the past dates as expiration for bucket lifecycle rules #8633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achouhan09
requested review from
liranmauda,
shirady,
naveenpaul1,
a team and
Neon-White
and removed request for
a team
achouhan09
changed the title
|
Hey @achouhan09
|
…le rules Signed-off-by: Aayush Chouhan <[email protected]>
|
Hi @romayalon |
Signed-off-by: Aayush Chouhan <[email protected]>
shirady
reviewed
Jan 5, 2025
| @@ -44,6 +44,7 @@ exports.empty_filter_marker_lifecycle_configuration = empty_filter_marker_lifecy | |||
|
|
|||
| function date_lifecycle_configuration(Bucket, Key) { | |||
| const now = new Date(Date.now()); | |||
| now.setDate(now.getDate() + 1); // Increases date by 1 day; past/current dates can't be set | |||
There was a problem hiding this comment.
Could you change the name of the variable? as it is not "now" anymore... (I saw it in more places).
Comment on lines
+546
to
+550
| await s3.putBucketLifecycleConfiguration(putLifecycleParams) | ||
| .catch(error => { | ||
| assert(error.code === 'InvalidArgument', 'Expected InvalidArgument: expiration date in the past'); | ||
| console.log('Expected error received, expiration date in the past'); | ||
| }); |
There was a problem hiding this comment.
Is there a special reason for using the promise chain here?
| @@ -63,8 +64,31 @@ function date_lifecycle_configuration(Bucket, Key) { | |||
| } | |||
| exports.date_lifecycle_configuration = date_lifecycle_configuration; | |||
|
|
|||
| function past_date_lifecycle_configuration(Bucket, Key) { | |||
There was a problem hiding this comment.
Could you reuse the previous definition of date_lifecycle_configuration and make the change you need on this function's output?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: