Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix or remove set_keep_alive_whitespace_interval #8569

Open
nadavMiz opened this issue Dec 2, 2024 · 0 comments
Open

fix or remove set_keep_alive_whitespace_interval #8569

nadavMiz opened this issue Dec 2, 2024 · 0 comments

Comments

@nadavMiz
Copy link
Contributor

nadavMiz commented Dec 2, 2024

Environment info

  • NooBaa Version: VERSION
  • Platform: Kubernetes 1.14.1 | minikube 1.1.1 | OpenShift 4.1 | other: specify

currently when complete_multipart_upload takes too long we send headers to show progress to the cluster, to prevent the client from closing the connection. since we send the headers to keep the connection, we can't write new headers (we get error ERR_HTTP_HEADERS_SENT). currently this happens for version-id and encryption. since we only link the file and don't really copy it, complete multipart upload should not take that long. it should only happen in case on problems with the file system that make the command take a lot of time (see #8524). we should decide if we want to remove set_keep_alive_whitespace_interval function, or to fix it in case we want to keep it

original keep alive issue: #6591. this PR was originally added when we copied the parts, and complete multipart upload time was relative to the file size

More information - Screenshots / Logs / Other output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant