NC | Noobaa Service Does Not Contain --unhandled-rejections=warn

[shirady]

Environment info

• NooBaa Version: current, 5.18.0
• Platform: NC

Actual behavior

1. When looking at noobaa.service file we have this line:
   

   noobaa-core/src/deploy/noobaa.service

   Line 10 in 6639c90

   ExecStart=/usr/local/noobaa-core/bin/node /usr/local/noobaa-core/src/cmd/nsfs.js

Expected behavior

1. When looking at the package.json file we are running node js scripts with --unhandled-rejections=warn:
   

   noobaa-core/package.json

   Line 32 in 6639c90

   "nsfs": "node --unhandled-rejections=warn src/cmd/nsfs",

Steps to reproduce

1. none

More information - Screenshots / Logs / Other output

none

[romayalon]

@dannyzaken @guymguym @shirady
We discussed it a few weeks ago when had the previous PANIC - (due to process.memoryUsage() failure)
Danny offered an idea that without --unhandled-rejections=warn we actually handle the issues we observe and not just getting warnings that later on being ignored.

Also, there was a suggestion to have another listener for unhandled rejections on panic.js similarly to
process.on('uncaughtException', err => panic('process uncaughtException', err));

[shirady]

I would add that I think that if we decide not to add the flag, a comment about it can be useful - when reading it and comparing to package.json examples and also noobaa-cli we always have this --unhandled-rejections=warn.

noobaa-core/src/deploy/noobaa-cli

Line 3 in 6639c90

./bin/node --unhandled-rejections=warn ./src/cmd/manage_nsfs.js "$@"