Bucket notification- The connection file as of now doesnot check the connectivity as soon as the notification executes it empties the folder

[ramya-c3]

Environment info

• NooBaa Version: 4.18
• Platform: standalone

Actual behavior

1.Even though the connection is not successful the log file gets emptied on execution of notification executable.

NOTIFICATION_LOG_DIR; /usr/local/noobaa-core/node/bin/node /usr/local/noobaa-core/src/cmd/manage_nsfs.js notification

Expected behavior

1.It should wait till the connection is restored before emtying the directory

Steps to reproduce

More information - Screenshots / Logs / Other output

[alphaprinz]

This is not the behaviour I'm seeing.
When notificator is ran while external server is done, failed notifications are re-written in the NOTIFICATION_LOG_DIR.
Note that notification log filename is different.
Once external server is up (and notificator is re-ran), all failed notification will be sent.

If you're seeing a different behaviour please detail the scenario, provide logs and content of the NOTIFICATION_LOG_DIR before and after relevant steps.

As a side note, the specified command mentions NOTIFICATION_LOG_DIR, but does not set it.
You need to either set in the command, eg
NOTIFICATION_LOG_DIR=/path/to/dir /usr/local/noobaa-core/node/bin/node /usr/local/noobaa-core/src/cmd/manage_nsfs.js notification
or set the NOTIFICATION_LOG_DIR in the config file.