Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor contrast for active tab with hidden file names on macOS .env #106

Open
adampatterson opened this issue Nov 3, 2019 · 6 comments
Open

Comments

@adampatterson
Copy link

This might be more me than the theme, but I can not see the .env file at all in the tab. If there is a setting or an option to enable/disable that would be great. I was not able to find anything obvious.

I have File Colors disabled, and the related issues showed a fix when updated to 2019.1.3

image

The contrast in the sidebar is fine.

image

image

PHP Storm Build 2019.2.4

@arcticicestudio
Copy link
Contributor

Related to #99


Hi @adampatterson 👋, thanks for your contribution 👍

Looks like this is related (or almost a duplicate) of #99. The problem with VCS ignored files are unfortunately a well-known problem or better named a missing feature from the theme API to better handle situations where multiple color are combined.
I'm still trying to figure out how to solve this tricky design without breaking the theme's appearance and feeling while also keep track of reported problems to the Jetbrains bug tracker in order to fix this within the theme API itself.

@adampatterson
Copy link
Author

Thanks for the quick reply,

Would it help to open an issue with JetBrains?

Tom1206 added a commit to Tom1206/nord-jetbrains that referenced this issue May 27, 2020
The editor tabs are now controlled in nord.theme.json instead of nord.xml, allowing better support if theme is used with another editor color theme.
The activated background color is one step darker, now blending nicely with all the subtle lines separating the different ui elements.
The hover color is a simpler light color (like all the buttons in the interface), instead of a deprecated dark mask.

The tool window header no longer changes on focus change. The bright blue line indicates nicely with tool window or editor tab is active. It allows for a simpler UI, with less distracting contrast, more inline with VS Code for exemple. The header now blends smoothly with the ui lines.
The tool window tabs are completely revamped. Before they used standard Darkula colors, causing various visibility problems (nordtheme#106 & nordtheme#99).
Now active tabs are indicated by the standard nord8 color. Once again the goal was to minimized useless contrast outside the main editor window, limiting distraction while keeping ui readability.

Probably closes nordtheme#99 & partly nordtheme#106
@duboiss
Copy link

duboiss commented Jul 4, 2020

Any news ?

@arcticicestudio
Copy link
Contributor

This is still an ongoing topic and there might be a solution by revisiting the current syntax theme file that might include definitions from the “old“ theme API that are now in conflict with the new theme API, but it requires more reproduction and testing.

@arcticicestudio arcticicestudio added the Hacktoberfest This repository participates in the Hacktoberfest label Oct 8, 2020
@dronezzzko
Copy link

dronezzzko commented Oct 29, 2020

Found a workaround:

  1. File | Settings | Version Control | File Status Colors
  2. Select Ignored → Unselect File Status Color

image
image

Here's also a good reference: https://www.jetbrains.com/help/idea/file-status-highlights.html

@duboiss
Copy link

duboiss commented Oct 29, 2020

Yes, already explained here: #57 :)

@arcticicestudio arcticicestudio removed the Hacktoberfest This repository participates in the Hacktoberfest label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants