Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embeds: Link "See Full Results" to the race detail page, not state page #101

Open
alykat opened this issue Jan 24, 2024 · 0 comments
Open

Embeds: Link "See Full Results" to the race detail page, not state page #101

alykat opened this issue Jan 24, 2024 · 0 comments
Assignees
@brentajones
Labels
Priority: Low This is of low importance. Take care of other issues before this.

Comments

@alykat
Copy link
Member

alykat commented Jan 24, 2024 •
edited
Loading

Pointed out by Anandita on the NPR One team: On our results embeds, when we enable the "see full results" links, the link points to the state page, rather than the race detail view. When we have multiple results in an embed (as we did for NH), this means we have 2 links that point to the same place. And the resulting interaction pattern isn't ideal: click a link -> arriving at a view that's not terribly different from where the user came from -> having to click an additional link for those detailed results.

image
brentajones added a commit that referenced this issue Feb 2, 2024
@brentajones
fix embeds results links; closes #101
da5049d
@alykat alykat added Priority: Low This is of low importance. Take care of other issues before this. and removed Priority: Normal labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brentajones brentajones

Labels
Priority: Low This is of low importance. Take care of other issues before this.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alykat @brentajones