Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate "show link/data when it's midnight local time" logic #98

Open
alykat opened this issue Jan 23, 2024 · 1 comment
Open

Re-evaluate "show link/data when it's midnight local time" logic #98

alykat opened this issue Jan 23, 2024 · 1 comment
Assignees
Labels
Priority: Low This is of low importance. Take care of other issues before this.
Milestone

Comments

@alykat
Copy link
Member

alykat commented Jan 23, 2024

Should it all be based on midnight ET instead?

For NH (admittedly an edge case), @brentajones added this temporary fix:

I didn't like promoting a page of results that don't exist yet for most people, so I temporarily added a day on to the calculation of what day it is. Results should work for everyone now. We can figure out a more elegant fix (if a fix is necessary) tomorrow. We can remove the added day before 2/2 so the SC link doesn't show up earlier than expected.

@alykat alykat added Priority: Normal bug Something isn't working labels Jan 23, 2024
@alykat alykat added this to the I - Week of Jan. 29 milestone Jan 30, 2024
@alykat
Copy link
Member Author

alykat commented Feb 1, 2024

NH fix has been rolled back. Moving this to low-pri/backlog.

@alykat alykat removed this from the I - Week of Jan. 29 milestone Feb 1, 2024
@alykat alykat added Priority: Low This is of low importance. Take care of other issues before this. and removed Priority: Normal bug Something isn't working labels Feb 1, 2024
@alykat alykat added this to the Z - Backlog milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low This is of low importance. Take care of other issues before this.
Projects
None yet
Development

No branches or pull requests

2 participants