Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test notification support #14

Open
thomaswilburn opened this issue Dec 30, 2019 · 4 comments
Open

Test notification support #14

thomaswilburn opened this issue Dec 30, 2019 · 4 comments
Milestone

Comments

@thomaswilburn
Copy link

Notifications in an initial test were flaky, and this may have to do with setInterval throttling when the tab isn't active. Investigate any other possibilities, and investigate moving the update mechanism into a web worker to avoid getting throttled.

@alykat
Copy link
Member

alykat commented Jan 29, 2020

Bug report from a station on the embedded version:

One other thing I just noticed though: The “Notify me about new posts” function doesn’t seem to work cross-browser. Safari gives me an option to allow notifications when I click that checkbox (which appeared checked when I started, btw – I don’t know if that’s it’s intended behavior or not but it made me think it was enabled by default). But FireFox throws an error: “The Notification permission may only be requested in a top-level document or same-origin iframe”. And Chrome doesn’t respond at all, not even with a console error, but I assume it’s also a security error. Silly Safari.

@thomaswilburn
Copy link
Author

Ah, okay. We'll have to hide that for embeds, then.

@thomaswilburn
Copy link
Author

Honestly, at this point I'm thinking we should lose the notifications by default, and consider them for further development at a later date. They're a neat idea, and I'm pretty sure we could make them work, but I don't really relish having a conversation with editors/reporters about "yes, it works on non-NPR machines, trust me," and station support seems like it could be a minefield.

@alykat
Copy link
Member

alykat commented Jan 29, 2020

Makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants