You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
As an example, the getJobStatus function accepts a full span as a parameter, rather than a span context.
I believe I did this to keep noise down for lower-level things like health checks, in that I didn't believe these functions warranted a separate span, when I really just needed them to log to a parent span.
Two things should be done:
Document everywhere this is being done. Should only be a handful of places if memory serves. If people will be expecting each function to have its own span, I want to be able to tell them the few times this won't be true.
Consider if its appropriate to keep this way, or change to a context. The trick will be balancing what's "standard" with what keeps tracing noise down.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As an example, the
getJobStatus
function accepts a full span as a parameter, rather than a span context.I believe I did this to keep noise down for lower-level things like health checks, in that I didn't believe these functions warranted a separate span, when I really just needed them to log to a parent span.
Two things should be done:
The text was updated successfully, but these errors were encountered: