Skip to content
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.

Reconsider passing a full span as param #188

Open
Mierdin opened this issue Jun 10, 2020 · 0 comments
Open

Reconsider passing a full span as param #188

Mierdin opened this issue Jun 10, 2020 · 0 comments

Comments

@Mierdin
Copy link
Member

Mierdin commented Jun 10, 2020

As an example, the getJobStatus function accepts a full span as a parameter, rather than a span context.

I believe I did this to keep noise down for lower-level things like health checks, in that I didn't believe these functions warranted a separate span, when I really just needed them to log to a parent span.

Two things should be done:

  • Document everywhere this is being done. Should only be a handful of places if memory serves. If people will be expecting each function to have its own span, I want to be able to tell them the few times this won't be true.
  • Consider if its appropriate to keep this way, or change to a context. The trick will be balancing what's "standard" with what keeps tracing noise down.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant