Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with recent clojurescript; goog.net.WebSocket constructor changed #76

Open
robgssp opened this issue Feb 24, 2021 · 1 comment

Comments

@robgssp
Copy link

robgssp commented Feb 24, 2021

src/cljs/weasel/impls/websocket.cljs:23 needs to wrap its arguments in an object, per https://google.github.io/closure-library/api/goog.net.WebSocket.html. Currently the code TypeError's on ClojureScript 1.10.773.

@alechstong
Copy link

alechstong commented Mar 23, 2021

Yeah, please fix this.

until then, 1.10.520 works fine

Edit:
After looking into it a bit more, it seems to me that we just need to bump weasel's clojurescript to 1.10.773, which uses closure lib v20210302. And it does not need it in an object.

https://github.com/google/closure-library/blob/169a1d1d25cbe04eef4a395c084e59ae927f1438/closure/goog/net/websocket.js#L52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants