Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing doc to include instructions to set up Earthdata Login credentials on a fork so integration tests can run on PRs #773

Closed
mfisher87 opened this issue Jul 23, 2024 · 9 comments
Labels
documentation Improvements or additions to documentation

Comments

@mfisher87
Copy link
Collaborator

mfisher87 commented Jul 23, 2024

Should probably be the first step we instruct contributors to do after forking.

@Sherwin-14
Copy link
Contributor

@mfisher87 Would'nt this encompass just a block(having the username and password) with directions?

@mfisher87
Copy link
Collaborator Author

mfisher87 commented Jul 24, 2024

image

I'm thinking we can maybe make it a sub-bullet of the second bullet on the contributing document?

If we do that, I think we should make "fork" and "setup dev environment" separate bullets, so there would be 4 top-level bullets, and bullet 2 would have the sub-bullet explaining secrets setup. What do you think?

@Sherwin-14
Copy link
Contributor

It's perfect! Let me have a look into that as well once I resolve other ones :)

@mfisher87
Copy link
Collaborator Author

🙇 Thanks, Sherwin!

@Sherwin-14
Copy link
Contributor

Is this one urgent or is it something we can hold for now?

@mfisher87
Copy link
Collaborator Author

mfisher87 commented Jul 24, 2024

I don't feel that it's urgent :) For now I'll un-assign you in case someone else feels like tackling it in the short-term!

@mfisher87 mfisher87 added the documentation Improvements or additions to documentation label Jul 24, 2024
@mfisher87
Copy link
Collaborator Author

Will be OBE by #811

@chuckwondo
Copy link
Collaborator

OBE by #818

@mfisher87
Copy link
Collaborator Author

mfisher87 commented Sep 25, 2024

Thank you, Chuck! This work will also be useful to icepyx :)

cc @JessicaS11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

No branches or pull requests

3 participants