Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deployment faster #416

Open
carpawell opened this issue Jul 8, 2024 · 0 comments
Open

Make deployment faster #416

carpawell opened this issue Jul 8, 2024 · 0 comments
Labels
enhancement Improving existing functionality I3 Minimal impact performance More of something per second S3 Minimally significant U4 Nothing urgent

Comments

@carpawell
Copy link
Member

carpawell commented Jul 8, 2024

Is your feature request related to a problem? Please describe.

I'm always frustrated when I have to wait for deployment for minutes, not seconds. Most of the deployment steps are simple and do not require complex computations. In fact, most of the time nodes just do nothing waiting next block.

Describe the solution you'd like

General rule: do not put step's TXs to the pool one by one, more of them can be sent to RPC node and accepted in a single block.

Have some suggestions (must be reviewed):

  1. Parallelize initial preparation (e.g. roles can be set at a time), most of them do not depend on each other (GAS distribution is an exception)
  2. Parallelize contract deployment, most of them do not require the others' hashes (also it is possible to deploy the Proxy contract and replenish it in a single transaction)

Describe alternatives you've considered

Make it even more complex but faster: do not parallelize request sending but place steps in a single transaction.

Additional context

#410 is the first try to make it faster. Saved some blocks in certain situations, made running our development envs more convenient.

@carpawell carpawell added the enhancement Improving existing functionality label Jul 8, 2024
@roman-khimov roman-khimov added U4 Nothing urgent S3 Minimally significant I3 Minimal impact performance More of something per second labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I3 Minimal impact performance More of something per second S3 Minimally significant U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants