-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website: replace deleted assertion extensions #161
Comments
Oh geez, is Fluent Assertions core compatible? |
It says so:
When we started porting, at that time it wasn't and so sample used to show how to configure solution in .NET Core uses Shouldy as well. At this level of usage, they look the same:
|
@amirrajan what's your take about it? (A) Convert every assertion to the form I'd go for B, or C as second place. |
@amirrajan now syntax highlighting seems to work, maybe not perfect but still... How should we move on with this issue? Maybe it's a good time to copy contents from gists to page, and at the same time replace assertions with the one we choose. |
BTW it seems there's a typo in bulleted list above (A ... D): points B and C are the same, and at this point it's not really clear what was the alternative to FluentAssertions form: Shouldy? previous snake_case style? |
I'd say got with FluentAssertions and whatever casing convention they support. |
@amirrajan , at some point during the port to .NET Core, we decided to drop almost all assertion extensions from NSpec library, only a few remained:
IsTrue
,IsFalse
,ShouldBeTrue
,ShouldBeFalse
.This means that many code examples in website should be modified because of this 😰
PS for those remaning assertions: naming was changed to classical .NET style. If there's pressure, we can rename them with previous style (
foo_bar_baz
).The text was updated successfully, but these errors were encountered: