Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have mix-cli figure out the entity type in entities:configure #209

Open
grof opened this issue Dec 11, 2023 · 0 comments
Open

Have mix-cli figure out the entity type in entities:configure #209

grof opened this issue Dec 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@grof
Copy link
Collaborator

grof commented Dec 11, 2023

The V4 UpdateEntity endpoint expects to be explicitly given the entity type in the body of the request, even though this is not a property that can actually be updated with this endpoint. mix.cli users are currently forced to provide the entity-type which does not provide the best of experiences.

A solution is have mix-cli query the GetEntity endpoint first to retrieve the entity type and proceed with it for the call to the UpdateEntity endpoint.

But providing this also brings up more error scenarios to consider. For instance, we cannot let users change the type of a base entity and it would be nice to capture this and warn users about it. In the current implementation, "base" is not a possible values for the --entity-type flag so we don't have this issue. All this to say that this is not only about grabbing the entity type from the GetEntity endpoint, we also need to think about the differnt paths the interaction can take after.

@grof grof added the enhancement New feature or request label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant