Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"The Death & Resurrection Show" by "Killing Joke": an error has occurred when searchin… #1683

Open
Lucki opened this issue Aug 21, 2024 · 3 comments
Labels
bug This issue identifies a bug in Nuclear.

Comments

@Lucki
Copy link
Contributor

Lucki commented Aug 21, 2024

Fill in the form to describe your problem
I have a problem with: "The Death & Resurrection Show" by "Killing Joke" https://open.spotify.com/track/2JUo8iX8FC05xd9GEpw9BI
It happens when: I try to play it/Adding the song to a queue
My OS is: Linux/Flatpak
I'm using Nuclear version: 0.6.38

Additional context
config.json

When adding to the queue, the entry stays red and rotates forever, reporting an error has occurred when searchin…

@Lucki Lucki added the bug This issue identifies a bug in Nuclear. label Aug 21, 2024
@nukeop
Copy link
Owner

nukeop commented Aug 21, 2024

Likely due to: distubejs/ytdl-core#92

@GearKite
Copy link

Might not be that.

At queue.ts#L197 if a song has a verified video, but that video is not returned in the search results, streamData will start with undefined ([undefined, ...]), which is then passed to resolveSourceUrlForTheFirstStream and causes a TypeError: Cannot read property 'stream' of undefined at queue.ts#L257.

Can also check that when disabling stream verification, this doesn't happen.

@nukeop
Copy link
Owner

nukeop commented Oct 18, 2024

That's a great observation. Unfortunately Youtube returns different search results for different people. If there's already a verified stream, it should use it without even searching for it. The search can happen later, so that the list of alternative streams can be populated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue identifies a bug in Nuclear.
Projects
None yet
Development

No branches or pull requests

3 participants