You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Consider dropping Sync syntax altogether, since it is verbose and will lead to inconsistent syntax over time. For example ReduceCallable needs to be renamed to ReduceSyncCallable when ReduceAsyncCallable is implemented. The Server* class names follows this convention, but the *Callables don't.
AsyncSinkCallable stands out to MapSyncCallable/MapAsyncCallable/MapSyncCallable in verb ordering, suggesting consitent naming SinkAsyncCallable.
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
The text was updated successfully, but these errors were encountered:
For the reducer_handler stands out, suggesting rename reducer_instance
--> This we can change for sure
Consider dropping Sync syntax altogether,
---> For this we might be considering this in the next iteration during refactoring, I want to make the type checking stricter for servers which support multiple types (sync, async, etc) so that we have better handling of inconsistencies
AsyncSinkCallable stands out to MapSyncCallable
Agreed, will change this
You're welcome, thanks for considering this.
These are of course just nice-to-have breaking changes that you should wait and bundle with other API changes you plan.
I just tried to get an overview of the server classes fingerprints (
pynumaflow 0.7.0
);reducer_handler
stands out, suggesting renamereducer_instance
.Sync
syntax altogether, since it is verbose and will lead to inconsistent syntax over time. For exampleReduceCallable
needs to be renamed toReduceSyncCallable
whenReduceAsyncCallable
is implemented. TheServer*
class names follows this convention, but the*Callable
s don't.AsyncSinkCallable
stands out toMapSyncCallable
/MapAsyncCallable
/MapSyncCallable
in verb ordering, suggesting consitent namingSinkAsyncCallable
.Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
The text was updated successfully, but these errors were encountered: