Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more type-safe version compatibility check for monovertex #2076

Open
KeranYang opened this issue Sep 19, 2024 · 0 comments
Open

more type-safe version compatibility check for monovertex #2076

KeranYang opened this issue Sep 19, 2024 · 0 comments
Labels
area/mono-vertex Mono Vertex enhancement New feature or request good first issue Good for new contributors rust Rust

Comments

@KeranYang
Copy link
Member

Posting on behalf of @vigith :

Currently in mono vertex version check, we are directly comparing version strings. This is for both numaflow and sdk. This involves a lot of string manipulations, converting to semver Version type and converting back, which doesn't leverage the type check capability offered by rust. We should consider creating our own NumaflowVersion type to unify the comparison.

@vigith Please edit if this doesn't accurately reflect your thoughts. Thanks!

Message from the maintainers:

Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

For quick help and support, join our slack channel.

@KeranYang KeranYang added bug Something isn't working enhancement New feature or request good first issue Good for new contributors rust Rust area/mono-vertex Mono Vertex and removed bug Something isn't working labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mono-vertex Mono Vertex enhancement New feature or request good first issue Good for new contributors rust Rust
Projects
None yet
Development

No branches or pull requests

1 participant