Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If "when to show scores to students" is set to "never", the student's attempts listings page should not show the "review allowed from" date #327

Open
christianp opened this issue Jul 10, 2024 · 0 comments
Labels

Comments

@christianp
Copy link
Member

There's a missing case in the template for the attempts listing table that the student sees.

If the resource is set to never show scores to students, then they can't re-enter completed attempts in review mode. At the moment, if the "allow students to review attempts from" date is set, then this date is shown in the table, even if it's passed, which is confusing.

I think the template should check attempt.should_show_scores, and only show the date if it's True.

@christianp christianp added the bug label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant