From 68d39bf218dcb7361c1e4b592077ce4f58e46734 Mon Sep 17 00:00:00 2001
From: Sylvain Boissel <sylvain@ashtree.eu>
Date: Fri, 16 Sep 2022 17:57:09 +0200
Subject: [PATCH] A11y minor issues fix (#20)

* Attaching modal close button to modal title

* Fix minor accessibility issues

* Fix accessibility detail

* Fix sr-only links with the proper class from the dsfr (fr-sr-only)
---
 dsfr/templates/dsfr/link.html                     | 2 +-
 dsfr/templates/dsfr/quote.html                    | 2 +-
 dsfr/test/test_templatetags.py                    | 4 ++--
 example_app/templates/example_app/tags_index.html | 2 +-
 pyproject.toml                                    | 3 +--
 5 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/dsfr/templates/dsfr/link.html b/dsfr/templates/dsfr/link.html
index 29a5d4898..e2d63477e 100644
--- a/dsfr/templates/dsfr/link.html
+++ b/dsfr/templates/dsfr/link.html
@@ -3,5 +3,5 @@
   href="{{ self.url }}"
   {% if self.is_external %} target="_blank" rel="noopener noreferrer"{% endif %}
 >
-  {{ self.label }}{% if self.is_external %} <span class="sr-only">Ouvre une nouvelle fenêtre</span>{% endif %}
+  {{ self.label }}{% if self.is_external %} <span class="fr-sr-only">Ouvre une nouvelle fenêtre</span>{% endif %}
 </a>
\ No newline at end of file
diff --git a/dsfr/templates/dsfr/quote.html b/dsfr/templates/dsfr/quote.html
index 343dfb424..e60438f3a 100644
--- a/dsfr/templates/dsfr/quote.html
+++ b/dsfr/templates/dsfr/quote.html
@@ -10,7 +10,7 @@
           </li>
           {% for detail in self.details %}
             {% if detail.link %}
-              <li><a target="_blank" rel="noopener noreferrer" href="{{ detail.link }}">{{ detail.text }} <span class="sr-only">Ouvre une nouvelle fenêtre</span></a></li>
+              <li><a target="_blank" rel="noopener noreferrer" href="{{ detail.link }}">{{ detail.text }} <span class="fr-sr-only">Ouvre une nouvelle fenêtre</span></a></li>
             {% else %}
               <li>{{ detail.text }}</li>
             {% endif %}
diff --git a/dsfr/test/test_templatetags.py b/dsfr/test/test_templatetags.py
index 07ea13b41..2a4519743 100644
--- a/dsfr/test/test_templatetags.py
+++ b/dsfr/test/test_templatetags.py
@@ -451,7 +451,7 @@ def test_link_tag_rendered(self):
             href="http://example.com"
             target="_blank" rel="noopener noreferrer"
             >
-            Label of the link item <span class="sr-only">Ouvre une nouvelle fenêtre</span>
+              Label of the link item <span class="fr-sr-only">Ouvre une nouvelle fenêtre</span>
             </a>
             """,
             rendered_template,
@@ -491,7 +491,7 @@ def test_quote_tag_rendered(self):
                         <cite>Système de Design de l&#x27;État</cite>
                     </li>
                     <li>Detail sans lien</li>
-                    <li><a target="_blank" rel="noopener noreferrer" href="https://template.incubateur.net/">Detail avec lien <span class="sr-only">Ouvre une nouvelle fenêtre</span></a></li>
+                    <li><a target="_blank" rel="noopener noreferrer" href="https://template.incubateur.net/">Detail avec lien <span class="fr-sr-only">Ouvre une nouvelle fenêtre</span></a></li>
                     </ul>
                     <div class="fr-quote__image">
                     <img src="https://via.placeholder.com/150x150" class="fr-responsive-img" alt="" />
diff --git a/example_app/templates/example_app/tags_index.html b/example_app/templates/example_app/tags_index.html
index 1831d9b0d..425d2d64e 100644
--- a/example_app/templates/example_app/tags_index.html
+++ b/example_app/templates/example_app/tags_index.html
@@ -34,7 +34,7 @@ <h2>Composants encore non implémentés</h2>
       <ul>
         {% for tag, data in not_yet.items %}
           <li class="fr-mb-1w">
-            <a href="{{ data.doc_url }}" target="_blank" rel="noopener">{{ data.title }} <span class="sr-only">Ouvre une nouvelle fenêtre</span></a>
+            <a href="{{ data.doc_url }}" target="_blank" rel="noopener">{{ data.title }} <span class="fr-sr-only">Ouvre une nouvelle fenêtre</span></a>
           </li>
         {% endfor %}
       </ul>
diff --git a/pyproject.toml b/pyproject.toml
index 952564c2b..6b0e7068d 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -3,8 +3,7 @@ authors = ["Sylvain Boissel <sylvain.boissel@beta.gouv.fr>"]
 description = "Integrate the French government Design System into a Django app"
 license = "MIT"
 name = "django-dsfr"
-version = "0.9.1"
-
+version = "0.9.2"
 classifiers = [
   "Development Status :: 3 - Alpha",
   "Environment :: Web Environment",