🐛(frontend) add default toolbar buttons #355
Open
+36
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are overriding the default toolbar to add the markdown and ai buttons. By doing that we were missing some default buttons that are useful depend on the block type. This commit adds the default buttons to the toolbar.
AntoLC
force-pushed
the
feature/toolbar-attachment
branch
from
4f9bbf8
to
9d41ee0
Compare
| ).toBeVisible(); | ||
| await expect(page.locator('button[data-test="colors"]')).toBeVisible(); | ||
| await expect(page.locator('button[data-test="unnestBlock"]')).toBeVisible(); | ||
| await expect(page.locator('button[data-test="createLink"]')).toBeVisible(); |
There was a problem hiding this comment.
Just the add the BlockTypeSelect inside tests and good to me !
PanchoutNathan
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We are overriding the default toolbar to add the markdown and ai buttons.
By doing that we were missing some default buttons that are useful depend on the block type.
Proposal
Demo