[Ernest Yu] iP #619
Open
[Ernest Yu] iP #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In build.gradle, the dependencies on distZip and/or distTar causes
the shadowJar task to generate a second JAR file for which the
mainClass.set("seedu.duke.Duke") does not take effect.
Hence, this additional JAR file cannot be run.
For this product, there is no need to generate a second JAR file
to begin with.
Let's remove this dependency from the build.gradle to prevent the
shadowJar task from generating the extra JAR file.
Tkaixiang
reviewed
Sep 4, 2024
| private File file; | ||
| private final String filePath; | ||
|
|
||
| Storage(String filePath) { |
There was a problem hiding this comment.
Perhaps an access modifier could be added for the constructor here for the sake of completeness :)
Tkaixiang
reviewed
Sep 4, 2024
Comment on lines
63
to
64
| String[] arr = desc.split("/from"); | ||
| String[] arr2; |
There was a problem hiding this comment.
These could have better naming :) (though I would be too lazy too most of the times ngl)
Tkaixiang
reviewed
Sep 4, 2024
src/main/java/chatBot/bot/Ui.java
Outdated
Comment on lines
10
to
19
| Ui() { | ||
| this.scanner = new Scanner(System.in); | ||
| } | ||
|
|
||
| void showWelcome() { | ||
| System.out.print(HLINE + | ||
| " Hello! I'm 'B word'\n" + | ||
| " What can I do for you?\n" + | ||
| HLINE); | ||
| } |
There was a problem hiding this comment.
Could consider proper access modifiers for most methods in this class
Merge branch-A-Assertion to Master
Attempt to merge branch onto master
Merge Branch-A-Streams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bword
My services:
USE me with
find me at here (well im not providing the link duh 🙄 )
Free (just for you) 😉
this is an inline code