From 0fe0d4935da3916b57599b25ebe6962ee4573482 Mon Sep 17 00:00:00 2001 From: EltonGohJH Date: Fri, 1 Mar 2024 20:32:38 +0800 Subject: [PATCH] Update progress and add knowledge for EltonGohJH --- students/EltonGohJH/knowledge.md | 16 ++++++++++++++++ students/EltonGohJH/observations.md | 28 ++++++++++++++++++++++++---- students/EltonGohJH/progress.md | 15 +++++++++++++++ 3 files changed, 55 insertions(+), 4 deletions(-) diff --git a/students/EltonGohJH/knowledge.md b/students/EltonGohJH/knowledge.md index 76cda5365..f8ceb120d 100644 --- a/students/EltonGohJH/knowledge.md +++ b/students/EltonGohJH/knowledge.md @@ -63,3 +63,19 @@ The reason for this is that the developer of js-beautify has changed the way it This caused a lot of tests to fail and I had to spend a lot of time debugging it. Through this experience, I learned the importance of ensuring that changes are documented properly and correctly. + +### gomock +I have learned to use GoMock, a mocking framework for Golang, which streamlines the creation of mock objects for unit testing. It helps with decoupling components, enabling the simulation of complex behaviors and interactions. I am surprised how easy it to use to mock complex behaviours. +Will definitely use it for Golang testing next time! + +#### Resource used: +- [gomock docs](https://github.com/uber-go/mock) + +### Yarn workspaces +Yarn Workspaces is a feature of Yarn that simplifies handling multiple packages within a single repository by enabling shared dependencies and centralized script management. I learnt Yarn Workspaces while setting up the repository for the Twenty project. +Overall, it is a good experience as I learnt more alternatives to Lerna and NPM workspaces. + +#### Resource used: +- [Yarn workspaces docs](https://yarnpkg.com/features/workspaces) + + diff --git a/students/EltonGohJH/observations.md b/students/EltonGohJH/observations.md index 819d5a9f2..bdddea0d3 100644 --- a/students/EltonGohJH/observations.md +++ b/students/EltonGohJH/observations.md @@ -1,11 +1,31 @@ -### Project: Foo +### Projects I have worked on + +#### Mattermost +Mattermost is an open-source collaboration platform designed for secure communication throughout the entire software development lifecycle. It serves as a self-hostable alternative to Slack, offering similar functionalities with the added benefit of full control over hosting and management. + +### Twenty +Twenty CRM is a modern, open-source Customer Relationship Management (CRM) platform. It serves as an self-hostable alternative to Salesforce. -Give an intro to the project here ... ### My Contributions -Give a description of your contributions, including links to relevant PRs +In the [mattermost PR (approved not merged yet)](https://github.com/mattermost/mattermost/pull/26278). I addressed this [issue](https://github.com/mattermost/mattermost/issues/25991) where the CLI command to list the teams uses a magic number of 9999. Utilizing such large magic numbers presents two problems: it restricts the ability to list more than 9999 teams and could result in a request that is too large. To solve this, I implemented pagination for the request, with each page containing 200 teams. Subsequently, I updated the test cases to reflect the new expected behavior. + +In the [Twenty PR (merged)](https://github.com/twentyhq/twenty/pull/4198). I addressed an [issue](https://github.com/twentyhq/twenty/issues/4181) reported by a user concerning LinkedIn school URLs not parsing correctly. Upon investigating the issue on the frontend, I discovered that the existing regex was only configured to support company URLs. To resolve this, I updated the regex to also accommodate school URLs and conducted tests to ensure the fix was effective. + ### My Learning Record -Give tools/technologies you learned here. Include resources you used, and a brief summary of the resource. \ No newline at end of file +### gomock +I have learned to use GoMock, a mocking framework for Golang, which streamlines the creation of mock objects for unit testing. It helps with decoupling components, enabling the simulation of complex behaviors and interactions. I am surprised how easy it to use to mock complex behaviours. +Will definitely use it for Golang testing next time! + +#### Resource used: +- [gomock docs](https://github.com/uber-go/mock) + +### Yarn workspaces +Yarn Workspaces is a feature of Yarn that simplifies handling multiple packages within a single repository by enabling shared dependencies and centralized script management. I learnt Yarn Workspaces while setting up the repository for the Twenty project. +Overall, it is a good experience as I learnt more alternatives to Lerna and NPM workspaces. + +#### Resource used: +- [Yarn workspaces docs](https://yarnpkg.com/features/workspaces) diff --git a/students/EltonGohJH/progress.md b/students/EltonGohJH/progress.md index e69de29bb..dbe2470d0 100644 --- a/students/EltonGohJH/progress.md +++ b/students/EltonGohJH/progress.md @@ -0,0 +1,15 @@ +| Week | Achievements | +| ---- | ------------ | +| 1 | Help prepared idea & facilitated Saturday code sprint - MarkBind website making | +| 3 | Repo cleaning - Added tags to issues, added items to project road map, added summaries to issues, and cleaned up some issues. Examples: [Allow markbind serve to specify custom host #2382](https://github.com/MarkBind/markbind/issues/2382), [Optimize MarkBind for saving as PDF #2397](https://github.com/MarkBind/markbind/issues/2397), [UG: images appear in two places #2401](https://github.com/MarkBind/markbind/issues/2401) | +| 4 | Investigated: [UG: images appear in two places #2401](https://github.com/MarkBind/markbind/issues/2401) | +| 4 | Investigated and closed: [The collapsed page nav appears in the print view #2157](https://github.com/MarkBind/markbind/issues/2157) | +| 4, 5 | Reviewed: [MarkBind Template for Software Project Documentation #2400](https://github.com/MarkBind/markbind/pull/2400) | +| 5 | Reviewed: [Migrate stylelint to latest version #2292](https://github.com/MarkBind/markbind/pull/2425) | +| 5 | Discussed: [Use justified text formatting for tooltips #2420](https://github.com/MarkBind/markbind/issues/2420) | +| 5, 6 | Investigated and reviewed: [Fix external styles and script not hoisted #2414](https://github.com/MarkBind/markbind/pull/2414) | +| 6 | Reviewed: [Add line-numbers when wrapping is needed for printing #2431](https://github.com/MarkBind/markbind/pull/2431) | +| 6 | Investigated: [Tooltip artefact left over for annotation point #2432](https://github.com/MarkBind/markbind/issues/2432) | +| 6 | Reviewed and merged: [Disable pop over in a-point if there is no header and content passed by user #2436](https://github.com/MarkBind/markbind/pull/2436) | +| 6 | Investigated and fixed bug: [Utilize GitHub Actions to aid checking of commit message #2429](https://github.com/MarkBind/markbind/pull/2429) | +| 6 | Help fixed bug and merged: [Annotation content slot #2427](https://github.com/MarkBind/markbind/pull/2427) |