Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colours are not preserved when sharing timetables #3423

Open
limweiliang opened this issue Jan 12, 2023 · 1 comment · May be fixed by #3467
Open

Colours are not preserved when sharing timetables #3423

limweiliang opened this issue Jan 12, 2023 · 1 comment · May be fixed by #3467

Comments

@limweiliang
Copy link

When sharing timetables to different devices via QR code, the colours assigned to each module are not preserved across devices.
@li-kai
Copy link
Member

li-kai commented Jan 26, 2023

When sharing timetables, the query params contains all the necessary info to "copy over" the timetable. To make this work, we'll need to add both the theme and the color selection for each module to the query params.

It's a good idea. Though on the core team I think we have our hands full. If you or someone is interested in making this happen, please submit a PR our way. I can provide some pointers if anyone wants to take this on.

@leslieyip02 leslieyip02 linked a pull request Jul 27, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include colors and theme when sharing timetable leslieyip02/nusmods
2 participants
@li-kai @limweiliang