Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NotifyIcon references/centralize management code #173

Open
gbakeman opened this issue Aug 4, 2024 · 0 comments
Open

Update NotifyIcon references/centralize management code #173

gbakeman opened this issue Aug 4, 2024 · 0 comments
Assignees
@gbakeman
Labels
bug Something isn't working enhancement New feature or request
Milestone
2.3 Stable Release

Comments

@gbakeman
Copy link
Contributor

gbakeman commented Aug 4, 2024

The NotifyIcon is referenced throughout WinNUT.vb code and in other Forms that could make the state of it inconsistent.

  • Make the NotifyIcon instance private - any references in external code need to be removed and logic integrated into the main WinNUT form code.
  • Upgrade the UpdateIcon_NotifyIcon method in WinNUT.vb to handle all other cases throughout the class that affect the state of the NotifyIcon, and modify it accordingly. Also consider renaming this method to something like NotifyIcon_UpdateState
@gbakeman gbakeman added bug Something isn't working enhancement New feature or request labels Aug 4, 2024
@gbakeman gbakeman added this to the 2.3 Stable Release milestone Aug 4, 2024
@gbakeman gbakeman self-assigned this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbakeman gbakeman

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
2.3 Stable Release
Development

No branches or pull requests
1 participant
@gbakeman