Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use undefined rather than null for data fetching defaults #1265

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Jul 6, 2024

πŸ”— Linked issue

#1263
Fixes: #1216

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This updates the default values of error and data for useFetch, useAsyncData and useError in as well as upstream.
It is designed to be backwards compatible as well as upstream.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx force-pushed the feat/default-data-and-error branch 5 times, most recently from 12a5811 to 4dd914a Compare July 7, 2024 14:37
@wattanx wattanx force-pushed the feat/default-data-and-error branch from 4dd914a to 7bae15d Compare July 10, 2024 13:57
@wattanx wattanx marked this pull request as ready for review July 12, 2024 03:04
Comment on lines +112 to +117
nuxt.options.experimental = (
await applyDefaults(
{ future: NuxtConfigSchema.future, experimental: NuxtConfigSchema.experimental },
{ future: nuxt.options.future, experimental: nuxt.options.experimental }
)
).experimental
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only want to use the default values for future and experimental.

@wattanx wattanx requested a review from danielroe July 13, 2024 03:38
@serialine serialine mentioned this pull request Jul 15, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to port from upstream
3 participants