From bb3aaa78800a204484131b5af01de0f694188db3 Mon Sep 17 00:00:00 2001
From: Sean Budd <sean@nvaccess.org>
Date: Fri, 9 Feb 2024 15:47:01 +1100
Subject: [PATCH] handle bad summary for add-ons (#35)

An add-on submission failed due the manifest not containing expected keys.

submission: [Submit add-on]:  addon-datastore#2470
job failure: https://github.com/nvaccess/addon-datastore/actions/runs/7816410786/job/21321868676
Instead an error message should be posted
---
 _validate/createJson.py | 43 +++++++++++++++++++++++------------------
 1 file changed, 24 insertions(+), 19 deletions(-)

diff --git a/_validate/createJson.py b/_validate/createJson.py
index 930f67b..91f29a1 100644
--- a/_validate/createJson.py
+++ b/_validate/createJson.py
@@ -88,25 +88,30 @@ def _createDictMatchingJsonSchema(
 	except ValueError:
 		manifest._errors = f"Manifest version invalid {addonVersionNumber}"
 		raise
-	addonData = {
-		"addonId": manifest["name"],
-		"displayName": manifest["summary"],
-		"URL": url,
-		"description": manifest["description"],
-		"sha256": sha,
-		"addonVersionName": manifest["version"],
-		"addonVersionNumber": dataclasses.asdict(addonVersionNumber),
-		"minNVDAVersion": dataclasses.asdict(
-			MajorMinorPatch(*manifest["minimumNVDAVersion"])
-		),
-		"lastTestedVersion": dataclasses.asdict(
-			MajorMinorPatch(*manifest["lastTestedNVDAVersion"])
-		),
-		"channel": channel,
-		"publisher": publisher,
-		"sourceURL": sourceUrl,
-		"license": licenseName,
-	}
+
+	try:
+		addonData = {
+			"addonId": manifest["name"],
+			"displayName": manifest["summary"],
+			"URL": url,
+			"description": manifest["description"],
+			"sha256": sha,
+			"addonVersionName": manifest["version"],
+			"addonVersionNumber": dataclasses.asdict(addonVersionNumber),
+			"minNVDAVersion": dataclasses.asdict(
+				MajorMinorPatch(*manifest["minimumNVDAVersion"])
+			),
+			"lastTestedVersion": dataclasses.asdict(
+				MajorMinorPatch(*manifest["lastTestedNVDAVersion"])
+			),
+			"channel": channel,
+			"publisher": publisher,
+			"sourceURL": sourceUrl,
+			"license": licenseName,
+		}
+	except KeyError as e:
+		manifest._errors = f"Manifest missing required key '{e.args[0]}'."
+		raise
 
 	# Add optional fields
 	homepage = manifest.get("url")