-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When add-on publication date is added, the json file is not valid #39
Comments
Sorry, the issue seems to be in NVDA implementation: submissionTime has to be divided by 1000 in NVDA. I'lltest this locally with the wintenApps.json fileincluded in the store, and ifthis works I'll create a PR to fixup this.I think that creating a new issue in NVDA is not needed for this obvious error. |
Though another approach is to make the division in this repo. |
In fact, testing with NVDA dividing the submission time of Windows App Essential with // 1000, the issue is fixed. In this repo, we are multiplying the timestamp with * 1000. We may try to remove this and submit some add-on for testing. |
At this stage, the code is in the submission process. I would encourage making the fix in NVDA as appropriate |
I've created nvaccess/nvda#17193 PR. I'll mark this as ready for review since all checks pass locally. |
Steps to reproduce
I think that somekindof encoding error is produced when creating the json file.
The text was updated successfully, but these errors were encountered: