Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the add-on store, add-ons seem not to be translated randomly #17527

Open
nvdaes opened this issue Dec 14, 2024 · 2 comments · May be fixed by nvaccess/addon-datastore-validation#41
Open

In the add-on store, add-ons seem not to be translated randomly #17527

nvdaes opened this issue Dec 14, 2024 · 2 comments · May be fixed by nvaccess/addon-datastore-validation#41
Labels
bug feature/addon-store Features / behavior of the add-on Store rare / intermittent bug cannot be easily reproduced, bug happens intermittently
Milestone

Comments

@nvdaes
Copy link
Collaborator

nvdaes commented Dec 14, 2024

Steps to reproduce:

  1. Set NVDA to Spanish (es)
  2. Open the add-on store
  3. Select the Available add-ons tab
  4. Select an add-on with translated information, like clipContentsDesigner
  5. Press tab until the description is displayed.

Actual behavior:

Sometimes, the description appears in Spanish, and sometimes is presented in English.

Expected behavior:

The description should be presented in Spanish.

NVDA logs, crash dumps and other attachments:

n/a. This is related to the store itself.

Running transformations to generate views locally, using the addon-datastore-transform repo, and changing the code to log the availableLanguages without writing add-ons, we can see that "es" and "ES", in lowercase and uppercase, both are available. Discarding the "ES" language and running the transformation again, translations are available, but at this moment they aren't available when "ES" and "es" are in availableLanguages.
I think that this can be fixed tweaking the getAddonManifestLocalizations in the addon-datastore-validation repo, used to create the json file and to regenerate translations.
In this way, new add-ons shouldn't be affected by this problem, and when translations are regenerated it should disapear.
I think that we can triage and open this in NVDA's repo since it's affecting NVDA, @seanbudd

System configuration

NVDA installed/portable/running from source:

Installed or portable.

NVDA version:

NVDA 2024.4.1

Windows version:

n/a.

Name and version of other software in use when reproducing the issue:

n/a

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes.

Have you tried any other versions of NVDA? If so, please report their behaviors.

n/a

If NVDA add-ons are disabled, is your problem still occurring?

n/a

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

n/a

Commit of addon-datastore for testing

ff34ebae8dfb1a40b68c196a36cba0798607096c

@nvdaes nvdaes added bug p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. rare / intermittent bug cannot be easily reproduced, bug happens intermittently labels Dec 14, 2024
@SaschaCowley SaschaCowley added this to the 2025.1 milestone Dec 16, 2024
@SaschaCowley SaschaCowley added the feature/addon-store Features / behavior of the add-on Store label Dec 16, 2024
@nvdaes nvdaes removed p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Dec 19, 2024
@nvdaes
Copy link
Collaborator Author

nvdaes commented Dec 19, 2024

@seanbudd and @SaschaCowley , I've removed the triaged and priority labels according to current guidelines for triaging. I think that this is ready to be triaged.

@nvdaes
Copy link
Collaborator Author

nvdaes commented Dec 19, 2024

This has been added to the 2025.1 Milestone, so I understand that this is ready to start working. I removed the triaged and p3 labels before seing that the milestone was added by NV Access.
So I'll start working on the addon-datastore-validation repo, and if/when this is triaged, we can add the changelog to NVDA if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/addon-store Features / behavior of the add-on Store rare / intermittent bug cannot be easily reproduced, bug happens intermittently
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants