feat: Make aws_alb_listener default_action block configurable
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The `alb_listeners` now requires a `default_action.type` whenever you are not using `alb_listeners`' default value. To use the previous default behavior, use a `default_action.type` of `forward`.
jbonnier
force-pushed
the
feat/make-alb-listners-default-action-configurable
branch
from
4c7184c to
b3ee4ca
Compare
alextrepa
approved these changes
Jun 7, 2024
jbonnier
deleted the
feat/make-alb-listners-default-action-configurable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The
alb_listenersnow requires adefault_action.typewhenever you are not usingalb_listeners' default value.GitHub Issue: # n/a
Proposed Changes
What is the current behavior?
The
alb_listeners'default_actionis always aforward.What is the new behavior?
The
alb_listeners'default_actionis now configurable.Checklist
Please check that your PR fulfills the following requirements:
To use the previous default behavior, use a
default_action.typeofforward.Other information
n/a