Install script: wrap vim.system calls to output nicer error messages if binary can't be found

[mrcjkb]

Hey 👋

The error is thrown here, because you don't have sh or git bash installed:

rocks.nvim/installer.lua

Lines 192 to 194 in ccdaaa1

	sc = vim.system({
	"sh",
	"configure",

We definitely need to wrap those calls to output nicer error messages...

Originally posted by @mrcjkb in #358 (comment)

ENOENT: No such file or directory is very confusing...

[mrcjkb]

Another idea:

If any installer dependencies are missing, show a warning in the intaller UI.

[softmoth]

Also this configure call in bootstrap.lua can fail if the luajit-devel package is missing. There's no message about why, it just says line it failed at the line that sources bootstrap.lua.

This exact issue may no longer be a problem once no longer depending on luarocks, but I guess the need for better error reporting will still be there.

[mrcjkb]

Also this configure call in bootstrap.lua can fail if the luajit-devel package is missing.

Unfortunately, that's an issue with the luarocks build scripts. Not much we can do in our install/bootstrap scripts.

Closing this issue, because it's been implemented in #549.
Also, we are focusing almost all of our resources on rocks development now. I don't think it'll be too long before we can replace luarocks 😄