Fix has a ward #1191
Merged
Fix has a ward #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1191 +/- ##
=======================================
Coverage 64.50% 64.50%
=======================================
Files 178 178
Lines 7051 7051
Branches 1672 1672
=======================================
Hits 4548 4548
Misses 1920 1920
Partials 583 583
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This worked well when I tested it. Any tips on how to make it fail? |
ericnewcomer
approved these changes
Jul 7, 2023
|
The issue was that when using has a ward rule, the next time one open the
node editor the stat and district parameters were not being loaded and the
validation was now failing even tho the flow definition was correct. That's
how I understood that
…On Fri, Jul 7, 2023, 10:05 PM Eric Newcomer ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#1191 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH6BOYU55IJ6464YMDKKELXPBT2FANCNFSM6AAAAAAZ7IKZJA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Right, I was able to repro that, but from what I can tell your changes in this PR address it as I can no longer. You seemed unsure in previous comments, so I was just asking before merging/shipping. |
|
I think I was confused because the flow I tried to test with was not saving
but later I was able to confirm that was the correct fix
…On Fri, Jul 7, 2023, 10:12 PM Eric Newcomer ***@***.***> wrote:
Right, I was able to repro that, but from what I can tell your changes in
this PR address it as I can no longer. You seemed unsure in previous
comments, so I was just asking before merging/shipping.
—
Reply to this email directly, view it on GitHub
<#1191 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH6BO5JSGWL6UO7EBRCPLDXPBURNANCNFSM6AAAAAAZ7IKZJA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.