Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 / v6.0.0 CreateParticipant has unlisted field status #316

Closed
samatgrow opened this issue Nov 30, 2023 · 6 comments · Fixed by #317
Closed

v3 / v6.0.0 CreateParticipant has unlisted field status #316

samatgrow opened this issue Nov 30, 2023 · 6 comments · Fixed by #317
Assignees
Labels

Comments

@samatgrow
Copy link

samatgrow commented Nov 30, 2023

Describe the bug
The v3 Python SDK's CreateParticipant has a status field that is not listed in the underlying API's documentation. I assume this is a holdover from the Participant class (used for returning event data), which correctly does have a status field. Am I misunderstanding the intention of the field?

Expected behavior
Expected SDK fields to match API, I'm not sure I'd ever want to set participant status (or that I'm allowed to).

SDK Version:
6.0.0

EDIT: To clarify this isn't blocking us at all, ignoring the field seems to have no consequences.

@samatgrow samatgrow added the bug label Nov 30, 2023
@samatgrow
Copy link
Author

samatgrow commented Dec 1, 2023

Similarly, CreateEventRequest has a read_only property that the API docs say is unsettable.

CreateEventRequest has a field calendar_id that is duplicated in CreateEventQueryParams -- the API docs say it should only be on the latter. Same thing in UpdateEventRequest.

@mrashed-dev
Copy link
Collaborator

@samatgrow Thank you so much for catching these inaccuracies! A PR will be open soon to make it better aligned with the API.

@samatgrow
Copy link
Author

Thanks for the quick fixes! Found a small typo, this time on 6.0.0b7: ListCalendersQueryParams should be ListCalendarsQueryParams.

@samatgrow
Copy link
Author

ListEventQueryParams accepts str for start and end while other methods that accept timestamps accept int which seemed a bit clearer from my perspective. I can open new issues for these if you like, just figured they didn't each deserve an entire issue but LMK what you prefer 😄

@mrashed-dev
Copy link
Collaborator

@samatgrow Thanks for reporting these issues! Having them in this issue is fine until it's closed by a PR, if you notice any other mistakes after the issue is closed feel free to open another one :)

Regarding your latest feedback, thanks for catching the typo on Calendars and the suggestion for Event. I'll add these two to the PR 😄

@mrashed-dev mrashed-dev linked a pull request Dec 11, 2023 that will close this issue
mrashed-dev added a commit that referenced this issue Dec 29, 2023
@mrashed-dev
Copy link
Collaborator

This fix is now released in v6 beta 8: https://pypi.org/project/nylas/6.0.0b8/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants