You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
_TAXIIEndpoint instances, and the ones that inherit from it, have context managers that do not implement the __del__ method.
This causes sessions in_HTTPConnection not to be closed by default when not using with, because the __exit__ method is not called.
Proposed solution: Add a __del__ method to _TAXIIEndpoint class, or implement a similar context manager (with a __del__ method) in _HTTPConnection class.
This issue seems like saying it's a problem that connections aren't closed if you don't call close(). I think programmers should just remember to call close(), or use a with statement to ensure it gets called. I am skeptical that it should be linked to a finalizer.
_TAXIIEndpoint
instances, and the ones that inherit from it, have context managers that do not implement the__del__
method.This causes sessions in
_HTTPConnection
not to be closed by default when not usingwith
, because the__exit__
method is not called.Proposed solution: Add a
__del__
method to_TAXIIEndpoint
class, or implement a similar context manager (with a__del__
method) in_HTTPConnection
class.Related to #37.
The text was updated successfully, but these errors were encountered: