Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nosferatu - v14 - Home #82

Open
staphon7 opened this issue Aug 16, 2021 · 7 comments
Open

Nosferatu - v14 - Home #82

staphon7 opened this issue Aug 16, 2021 · 7 comments

Comments

@staphon7
Copy link

staphon7 commented Aug 16, 2021

Hello there,

My operating system is Arch Linux.

Here is the output of advene --version:

  • Advene development version release/3.13.1-1-gf2abf4d7

How to reproduce the issue:

  • Launch Advene with ./bin/advene /<path_to>/Nosfertu_v14.azp.

Navigation and steps:
We are there: http://localhost:1234/packages/Nosferatu_v14/view/Home.

  1. Chapter: "This hypervideo"

  2. Chapter: "Settings things up"


Nota bene:
I have tested the https://archive.org/download/Nosferatu1922_201811/Nosferatu%201922.ogv file with "Nosferatu_v14.azp".
It matches almost perfectly.

As you know, if you decide to give that file as a link to the movie, you will have to generate the "Scene chance" and "Sound enveloppe" annotation types again.
Then, that if you wish - let me a comment -, I will look for and note what has to be fixed about the other annotation types - there might be some slight things to fix.
For example, in the "Nightmare triangle" annotation type, one of the shots - Nosferatu behind the bars - has to be adapted.
And concerning "nosfe.css", the classes "screenshot", "half_screenshot" and "screenshot_container" might have to be fixed.
Despite that, about "nosfe.css", one of the value "width" or "height" of "screenshot" and "half_screenshot", to respect the aspect-ratio of the image, should be set to "auto" - but this might not be what you want.

All that said, there might be a better idea, for both of us:
How about, after your agreement - comment in the issue - I check and fix the annotation types and then send you a "Nosferatu_v14_fixed.azp", or every exported annotation types files I fixed in "Nosferatu_v14.azp".
You could then import them and check if things are good to you.

This is just a proposition, if you don't want to change anything, it's obviously fine to me.


Thank you

@oaubert
Copy link
Owner

oaubert commented Aug 17, 2021

Hi. Thanks for all the detailed tests and suggestions. Your proposed approach is perfectly fine: fix things in your own copy of Nosferatu_v14 and I will merge them for the next release. Do not hesitate to add comments where you are uncertain.

@staphon7
Copy link
Author

staphon7 commented Aug 17, 2021

All right, I'll do the thing in my own copy of Nosferatu_v14.
In my above comment, I used the verb "to send" but I didn't say how to. Would you like me to send the file by email - to "contact alt advene dot org" - or using a github "PR"?

@oaubert
Copy link
Owner

oaubert commented Aug 17, 2021

Great. Yes, you can send it by e-mail at the indicated address.

@staphon7
Copy link
Author

Hello there,

  • What I did:

    • "Shot" annotation type fixed.
    • "Panel" annotation type aligned from the above one.
  • Note:
    As you may know, sometimes the shots begin/end with some blank - black or white - frames. I managed so that every shots start with a non blank frame. If this is a problem, just tell me.

Thank you

@staphon7
Copy link
Author

staphon7 commented Aug 30, 2021

Hello there,


Element A

  • Question about "Episode" annotation type:
    • The "Shot" and "Movie Part" annotation types include the whole movie, but the "Episode" does not: following the last annotation, named "Sacrifice", there are three missing shots.
      ==> Should I let it as this?

Element B

  • Purpose:

    • "Supernatural" annotation types
    • "Nightmare" annotation types
    • "fear" annotation types
    • "joy" annotation types
  • Questions:

    1. Sometimes the annotations do not last the entire shot.
      ==> Should I fix them to be the whole shot or let them as they are - fixing them anyway to keep their precision?

    2. Some annotations include some shots that have nothing - that is my opinion - to do with the type of annotation. See the below note
      As an example, concerning "fear" annotation type, I can give one of "Nina"'s annotations - shots 553-571 - where we can see Nosferatu behind a window holding the bars. I do not think he is feeling any fear, he rather looks thirsty ;)
      ==> Should I cut this kind of annotations into multiple annotations or not, and then ignore the wrong parts?

  • Note:
    About the second question, I must say this might specifically concern my example.


Element C

  • Question about "Supernatural" annotation type:
    • At "Shot 585" the content of the annotation is "num=581".
      • Have I got to change its content?
      • If yes, what would it be?
        I mean Nosferatu is drinking blood, but it is not so supernatural to me, and I can't find what else it could be. I'm not sure if this is what you meant.

Element D

  • Question about "Sound enveloppe" annotation type:
    I tried to build the annotation type again, since it is not the same movie file.
    Here are my settings:

    Name Value
    offset 0
    Interval 10
    number-of-samples 1000
    channel both
    value peak
    lower-db-limit -30

    It looks almost the same as the older one, but if you could have a memory of your own settings, I will be glad to apply them.

    In the mean time, with these settings, I obtain 507 annotations - compared to 506 in the older package - and the last of them is blank.
    ==> Should I delete it?


Thank you

@oaubert
Copy link
Owner

oaubert commented Aug 30, 2021

Hi. Thanks for the detailed report.
For A, you can extend the last Episode to cover the whole movie.
For B, annotations should be realigned. This should be doable by DNDing the reference annotation type on the annotation type to realign, there will be an Alignment menuitem. For the annotation content, let's keep it for the moment, we can discuss about the validity of fear annotation later on.
For C, it should be something like "Nosferatu drinking blood" (which, if you find it natural, would indicate that you have some Transsylvanian origin :-)
For D, The Sound enveloppe can be regenerated to match the movie.

@staphon7
Copy link
Author

staphon7 commented Sep 4, 2021

Hello there,

Everything is done but the "Text annotation" annotation type which is empty of annotations. Should I delete it?
I'm sorry about that last question, I should have thought about that in my last comment.
Right after your answer I'll do a last check and send the file to you.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants