Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat an empty features string as a no-op like Cargo does #566

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Treat an empty features string as a no-op like Cargo does #566

merged 5 commits into from
Oct 23, 2023

Conversation

HadrienG2
Copy link
Contributor

@HadrienG2 HadrienG2 commented Oct 22, 2023 •
edited
Loading

Fixes #565 . Draft because it depends on an un-merged change in clap_verbosity_flag => Not anymore, since use of Default was considered harmful.

obi1kenobi
obi1kenobi reviewed Oct 22, 2023
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
obi1kenobi
obi1kenobi reviewed Oct 22, 2023
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@HadrienG2 HadrienG2 marked this pull request as ready for review October 23, 2023 02:38
@obi1kenobi obi1kenobi merged commit e746555 into obi1kenobi:main Oct 23, 2023
32 checks passed
@obi1kenobi
Copy link
Owner

Thanks!

@obi1kenobi
Copy link
Owner

Queued up a new release, v0.24.1, in #567.

@HadrienG2 HadrienG2 mentioned this pull request Oct 23, 2023
Merged
@HadrienG2 HadrienG2 deleted the empty-features-str-is-no-op branch October 23, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obi1kenobi obi1kenobi obi1kenobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider accepting --features="" as a no-op like Cargo does
2 participants
@HadrienG2 @obi1kenobi