Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow relative or absolute paths for ignore files #23

Open
Ikutania opened this issue Jul 28, 2022 · 3 comments
Open

Allow relative or absolute paths for ignore files #23

Ikutania opened this issue Jul 28, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Ikutania
Copy link
Contributor

Currently ignore files require an absolute path to the file. It should allow relative paths from the workspace directory as well.

@obicons
Copy link
Owner

obicons commented Jul 28, 2022

I don’t think this is true. Please be aware the image on docker hub is not necessarily up to date. I think today we match by filename, and ignore the path.

@obicons obicons added the bug Something isn't working label Jul 28, 2022
@obicons obicons self-assigned this Jul 28, 2022
@obicons
Copy link
Owner

obicons commented Jul 28, 2022

You may try pulling the latest code, building a new Docker image, and then running like this (inside of demos/01):

docker container run  -t -v "$(pwd)":/src/ sa4u-z3 -c /src/compile_commands_dir/ -m /src/CMASI.xml -p /src/ex_prior.json  -i ex.cpp

You should see a message like this:

INFO: Skipping /src/ex.cpp because it is to be ignored

Ikutania added a commit to Ikutania/sa4u that referenced this issue Aug 1, 2022
Fixed:
Issue obicons#26, obicons#25, obicons#23, obicons#19

Refactored and reduced
Placed Debug keys into a single object
Ikutania added a commit to Ikutania/sa4u that referenced this issue Aug 3, 2022
Fixed:
Issue obicons#26, obicons#25, obicons#23, obicons#19

Refactored and reduced
Placed Debug keys into a single object
Ikutania added a commit to Ikutania/sa4u that referenced this issue Aug 3, 2022
Bug Fixes, Edits, and Updates

Fixed:
Issue obicons#26, obicons#25, obicons#23, obicons#19

Refactored and reduced
Placed Debug keys into a single object
Ikutania added a commit to Ikutania/sa4u that referenced this issue Aug 3, 2022
Bug Fixes, Edits, and Updates

Fixed:
Issue obicons#26, obicons#25, obicons#23, obicons#19

Refactored and reduced
Placed Debug keys into a single object
Ikutania added a commit to Ikutania/sa4u that referenced this issue Aug 4, 2022
Fixed:
Issue obicons#26, obicons#25, obicons#23, obicons#19

Refactored and reduced
Placed Debug keys into a single object
Ikutania added a commit to Ikutania/sa4u that referenced this issue Aug 5, 2022
Fixed:
Issue obicons#26, obicons#25, obicons#23, obicons#19

Refactored and reduced
Placed Debug keys into a single object
@obicons
Copy link
Owner

obicons commented Aug 6, 2022

@Ikutania how does this PR fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants