Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't introduce base for void attribute #76

Closed
maxonfjvipon opened this issue Dec 2, 2024 · 7 comments · Fixed by #78
Closed

Can't introduce base for void attribute #76

maxonfjvipon opened this issue Dec 2, 2024 · 7 comments · Fixed by #78
Assignees
@maxonfjvipon
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@maxonfjvipon
Copy link
Member

I'm trying to implement this feature: objectionary/eo#3529.
It requires us to put ∅ as base to void attributes.
EO:

[x] > main

XML:

<objects>
  <o name="main">
    <o base="∅" name="x"/>
  </o>
</objects>

While implementing I'm getting tests failed on verification step with next error: The object "∅" is not defined anywhere (unknown-name)

I think an exceptional case must be added to the unkhown-name check.
@maxonfjvipon
Copy link
Member Author

@yegor256 WDYT?

@yegor256
Copy link
Member

yegor256 commented Dec 2, 2024

@maxonfjvipon yes, definitely

@yegor256 yegor256 added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Dec 2, 2024
@maxonfjvipon
Copy link
Member Author

@yegor256 please assign me

@yegor256
Copy link
Member

yegor256 commented Dec 2, 2024

@maxonfjvipon go ahead

maxonfjvipon added a commit to maxonfjvipon/lints that referenced this issue Dec 2, 2024
@maxonfjvipon
fix(objectionary#76): add exception for void attribute with base
703fbf8
@maxonfjvipon maxonfjvipon mentioned this issue Dec 2, 2024
Merged
yegor256 added a commit that referenced this issue Dec 2, 2024
@yegor256
Merge pull request #78 from maxonfjvipon/fix/#76/void-attr-with-base
fe0bb5a 
fix(#76): add exception for void attribute with base
@yegor256
Copy link
Member

yegor256 commented Dec 2, 2024

@rultor release, tag is 0.0.14

@rultor
Copy link
Contributor

rultor commented Dec 2, 2024

@rultor release, tag is 0.0.14

@yegor256 OK, I will release it now. Please check the progress here.

@rultor
Copy link
Contributor

rultor commented Dec 2, 2024

@rultor release, tag is 0.0.14

@yegor256 Done! FYI, the full log is here (took me 7min).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxonfjvipon maxonfjvipon

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#76): add exception for void attribute with base maxonfjvipon/lints
3 participants
@yegor256 @rultor @maxonfjvipon