Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please ship symbols for graphics-hook64 so we can debug crashes it causes in our games #11684

Open
kg opened this issue Dec 31, 2024 · 2 comments

Comments

@kg
Copy link

kg commented Dec 31, 2024

Operating System Info

Windows 11

Other OS

No response

OBS Studio Version

30.2.3

OBS Studio Version (Other)

No response

OBS Studio Log URL

n/a. OBS is not running

OBS Studio Crash Log URL

n/a. OBS is not running

Expected Behavior

Since OBS is open source, if it insists on injecting graphics-hook64.dll into my game even though OBS is not running, that dll should be shipped with debug symbols

Current Behavior

The dll is injected into my game at startup regardless of whether OBS is running, and it appears to be involved in crashes when destroying swapchains. I can't investigate this further without symbols.

Steps to Reproduce

  1. Launch a SDL_GPU based game on a system with OBS installed
  2. Observe that graphics-hook64 gets loaded even though OBS isn't running
  3. Create and destroy swapchains repeatedly (I do this by spamming alt-enter to enter and exit fullscreen, which resizes/recreates the swapchain)
  4. Eventually you will crash
  5. There are no symbols

Anything else we should know?

See here where we get an AV inside the nvidia driver after calling a graphics-hook64 entry point:
image

Note that this is not a 'please fix graphics-hook64' issue report, I'm just asking for debug symbols to ship with future versions so it's easier to rule out OBS as the culprit when a crash happens with the dll loaded.

@derrod
Copy link
Member

derrod commented Dec 31, 2024

We do ship symbols with OBS, but they are not copied to the %PROGRAMDATA% folder the hook is loaded from. You can grab them from the zip or Program Files folder though.

Also this particular crash might be fixed with 31.0.

@kg
Copy link
Author

kg commented Dec 31, 2024

Thanks very much! You can close this then. It might be cool to have a 'where are the symbols.txt' file in the ProgramData folder for people like me who go looking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants