Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yield effect unused in aio #33

Closed
Sudha247 opened this issue Sep 19, 2022 · 2 comments
Closed

Yield effect unused in aio #33

Sudha247 opened this issue Sep 19, 2022 · 2 comments
Labels
good first issue

Comments

@Sudha247
Copy link
Contributor

https://github.com/ocaml-multicore/effects-examples/blob/master/aio/aio.ml#L16 defines Yield here, but it's not used anywhere in the rest of the scheduler. Was it supposed to be used somewhere or could we remove it?

(pointed out by @Leonidas-from-XIV)
@dhil
Copy link
Collaborator

dhil commented Sep 20, 2022

I suppose it is unused in this example (the echo server), and as such it could probably go. In general it can be quite useful as a primitive to force preemption rather than having to perform an IO operation.

@Sudha247
Copy link
Contributor Author

Fixed by #38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kayceesrk @dhil @Sudha247