Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish a common pbrt module and use it #41

Open
c-cube opened this issue Mar 18, 2022 · 3 comments
Open

publish a common pbrt module and use it #41

c-cube opened this issue Mar 18, 2022 · 3 comments

Comments

@c-cube
Copy link

c-cube commented Mar 18, 2022

hi 👋!

In this ocaml-protoc issue, I suggest to separate the runtime module of ocaml-protoc (originally lifted from ppx_deriving_protobuf) into its own package, to reduce runtime dependencies of code that uses protobufs. Since the runtime API is mostly the same, I think ppx_deriving_protobuf could also make use of that module, what do y'all think?

As a side note, it'd solve #9 (see the PR), and the performance of some of the functions has been improved a bit (mostly in relation to varint), see here and here.

@gasche
Copy link
Contributor

gasche commented Mar 19, 2022

Sounds like a good plan... especially if I'm not the one doing the work.

@c-cube
Copy link
Author

c-cube commented Mar 19, 2022

Alright :). The question is, where would this library live? I also like that the module here is called "protobuf", but there's an existing package of the same name on opam…

@gasche
Copy link
Contributor

gasche commented Mar 19, 2022

The question is, where would this library live?

No strong opinions here. If you and @mransan are willing to maintain it, it could live in the same source repository as ocaml-protoc, as a separate opam package. Or it could in its own repository.

I also like that the module here is called "protobuf", but there's an existing package of the same name on opam…

protobuf-runtime?

Note: protobuf (opam, dev repo) appears to be dormant, so you might try to reuse the name by asking kindly, but I'm not sure that the protobuf name more accurately describe this "minimal runtime code" than what's currently in the protobuf project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants