Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppx_metaquot should include location info #7

Open
whitequark opened this issue Jun 24, 2014 · 4 comments
Open

ppx_metaquot should include location info #7

whitequark opened this issue Jun 24, 2014 · 4 comments

Comments

@whitequark
Copy link
Contributor

Right now the type errors are confusing:

File "_none_", line 1:
Error: This pattern matches values of type Parsetree.expression
       but a pattern was expected which matches values of type
         Parsetree.expression_desc
@whitequark
Copy link
Contributor Author

A good test case for this problem:

[%expr fun x -> [%e Exp.variant (int_encoding typ) [%expr (Int64.to_string x)]]]

@charlesetc
Copy link

charlesetc commented Oct 16, 2016

+1 Absolutely

This would be awesome, if it just allowed you to pass in a single location that all the generated ast's would share.

@whitequark
Copy link
Contributor Author

@charlesetc That's already there; see https://github.com/alainfrisch/ppx_tools/blob/master/ppx_metaquot.ml#L28-L38

@charlesetc
Copy link

Just saw that! True - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants