Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #398

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Update README.md #398

merged 1 commit into from
Mar 21, 2023

Conversation

marrious11
Copy link
Contributor

@marrious11 marrious11 commented Mar 18, 2023

Proposed changes to the README file in the ocaml-ppx/ppxlib repository.
Signed-off-by: Mario [email protected]

@Burnleydev1
Copy link
Contributor

Hello, @marrious11 I would like to work you through the sign-off process if you don't mind.

Use git log to find the hash of the commit that you want to edit.

Run git rebase -i <enter the commit hash here> to start a rebase session that includes the commit you want to edit and its parent commit. This will open a text editor with a list of commits and instructions for how to edit them.

Find the line that corresponds to the commit you want to edit, and change the command from pick to edit. Save and close the file.

Run git commit --amend -s to make changes to the commit. This will open a text editor where you can modify the commit message and/or the contents of the commit.

After making your changes, save and close the file.

Run git rebase --continue to continue the rebase process. This will apply your changes and modify the commit history.
When you're done, run git push --force-with-lease origin patch-2

@marrious11
Copy link
Contributor Author

Hello, @Burnleydev1! Thank you so much for the guidelines.
This section about DCO has been troubling me ever since I started making an attempt to contribute here.

Proposed changes to the README file in the `ocaml-ppx/ppxlib` repository.
Signed-off-by: Mario <[email protected]>
Copy link
Collaborator

@panglesd panglesd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@marrious11
Copy link
Contributor Author

marrious11 commented Mar 20, 2023

Hi sir @panglesd, thank you 😃!
Please, can I close the PR now?
And too, I'd love to ask a few questions with regard to some info about the contribution to #389 as stated on the Outreachy website.

@panglesd
Copy link
Collaborator

Do not close the PR! It will be merged soon, I just wanted to leave some time to other ppxlib maintainer to step up in case there is some problem I did not see (English is not my first language).

And too, I'd love to ask a few questions with regard to some info about the contribution to #389 as stated on the Outreachy website.

You can ask them on the #389 issue, on discord or by email!

@marrious11
Copy link
Contributor Author

Alright sir @panglesd. Only one email was provided for us on the Outreachy website. But let me go on discord.

@panglesd panglesd merged commit 1c1e87f into ocaml-ppx:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants