Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] jose (0.10.0) #27128

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

ulrikstrid
Copy link
Contributor

@ulrikstrid ulrikstrid commented Dec 17, 2024

JOSE implementation for OCaml and ReasonML

CHANGES:
  • Upgrade mirage-crypto and remove cstruct (by @anmonteiro, special thanks to @hannesm for help with debugging a unexpected test failure)

CHANGES:

- Upgrade mirage-crypto and remove cstruct (by @anmonteiro, special thanks to @hannesm for help with debugging a unexpected test failure)
@ulrikstrid
Copy link
Contributor Author

The tests here seems strange that they would break on only ARM, either this is a bug in ptime (which we use for comparing the times) or something else is broken. Can we just disable the tests for ARM?

@hannesm
Copy link
Member

hannesm commented Dec 18, 2024

The error is "# [exception] Yojson__Safe.Util.Type_error("Expected int or null, got intlit", _)" -- since this is only on arm32 platform, may this be some kind of "the number is too big for the integer representation"?

I'd recommend to not disable tests for arm32, but mark it unavailable on that platform (available: arch != "arm32").

@ulrikstrid
Copy link
Contributor Author

Hopefully I did this correctly

@mseri
Copy link
Member

mseri commented Dec 19, 2024

Thanks

@mseri mseri merged commit 084c15a into ocaml:master Dec 19, 2024
3 checks passed
@ulrikstrid ulrikstrid deleted the release-jose-v0.10.0 branch December 19, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants