Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCaml 5.3.0: release candidate #27145

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

Octachron
Copy link
Member

This PR adds the three packages (ocaml-compiler, ocaml-base-compiler and ocaml-variants...+options) for the release candidate of OCaml 5.3.0.

Compared to the second beta release, the release candidate contains one fix for the new linking order check (in presence of pack), and fix for type expression generalization.

Simultaneously, this PR removes the compiler flag from the ocaml-compiler package and the non-windows host-system-* dependencies as discussed with @dra27 and @kit-ty-kate .


Changes since the second beta

Type system regression fix

  • 13690: some type expressions were incorrectly not generalized (because they
    were assigned to the wrong level pool)

Documentation update

  • 13666: Rewrite parts of the example code around nested lists in Chapter 6
    (Polymorphism and its limitations -> Polymorphic recursion) giving the
    "depth" function [in the non-polymorphically-recursive part of the example]
    a much more sensible behavior; also fix a typo and some formatting.
    (Frank Steffahn, review by Florian Angeletti)

Compiler user-interface and warnings:

  • 12084, +13669, +13673: Check link order when creating archive and when using
    ocamlopt.

dra27 and others added 2 commits December 18, 2024 22:06
The presence of the flag in both ocaml-base-compiler and ocaml-compiler
causes opam's invariant computation to produce a poor invariant:

e.g. opam switch create 5.3.0~beta2 produced an invariant of
  "ocaml-base-compiler" {= "5.3.0~beta2"} | "ocaml-compiler" {= "5.3.0~beta2"}
instead of the desired
  "ocaml-base-compiler" {= "5.3.0~beta2"}
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Tested locally on Linux/arm64

@raphael-proust
Copy link
Contributor

tested locally on linux/x86_64

for anyone interested:

  • checkout this branch
  • opam remote add testingtesting ./
  • add --repos=testingtesting to all the opam switch commands

@raphael-proust raphael-proust merged commit 95bfbde into ocaml:master Dec 19, 2024
1 of 2 checks passed
punchagan pushed a commit to punchagan/opam-repository that referenced this pull request Dec 20, 2024
punchagan pushed a commit to punchagan/opam-repository that referenced this pull request Dec 20, 2024
punchagan pushed a commit to punchagan/opam-repository that referenced this pull request Dec 20, 2024
punchagan pushed a commit to punchagan/opam-repository that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants