-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCaml 5.3.0: release candidate #27145
Merged
raphael-proust
merged 2 commits into
ocaml:master
from
Octachron:OCaml_5.3.0_release_candidate
Dec 19, 2024
Merged
OCaml 5.3.0: release candidate #27145
raphael-proust
merged 2 commits into
ocaml:master
from
Octachron:OCaml_5.3.0_release_candidate
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The presence of the flag in both ocaml-base-compiler and ocaml-compiler causes opam's invariant computation to produce a poor invariant: e.g. opam switch create 5.3.0~beta2 produced an invariant of "ocaml-base-compiler" {= "5.3.0~beta2"} | "ocaml-compiler" {= "5.3.0~beta2"} instead of the desired "ocaml-base-compiler" {= "5.3.0~beta2"}
kit-ty-kate
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Tested locally on Linux/arm64
tested locally on linux/x86_64 for anyone interested:
|
punchagan
pushed a commit
to punchagan/opam-repository
that referenced
this pull request
Dec 20, 2024
…didate OCaml 5.3.0: release candidate
punchagan
pushed a commit
to punchagan/opam-repository
that referenced
this pull request
Dec 20, 2024
…didate OCaml 5.3.0: release candidate!!!
punchagan
pushed a commit
to punchagan/opam-repository
that referenced
this pull request
Dec 20, 2024
…didate OCaml 5.3.0: release candidate!!!
punchagan
pushed a commit
to punchagan/opam-repository
that referenced
this pull request
Dec 20, 2024
…didate OCaml 5.3.0: release candidate!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the three packages (
ocaml-compiler
,ocaml-base-compiler
andocaml-variants...+options
) for the release candidate of OCaml 5.3.0.Compared to the second beta release, the release candidate contains one fix for the new linking order check (in presence of pack), and fix for type expression generalization.
Simultaneously, this PR removes the
compiler
flag from theocaml-compiler
package and the non-windowshost-system-*
dependencies as discussed with @dra27 and @kit-ty-kate .Changes since the second beta
Type system regression fix
were assigned to the wrong level pool)
Documentation update
(Polymorphism and its limitations -> Polymorphic recursion) giving the
"depth" function [in the non-polymorphically-recursive part of the example]
a much more sensible behavior; also fix a typo and some formatting.
(Frank Steffahn, review by Florian Angeletti)
Compiler user-interface and warnings:
ocamlopt.