-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External file for mapping machines to their position on the labmap #6
Comments
This is a good fit for the github.com/ocf/etc repo |
Shall we accomplish this with a Docker volume mapping and a simple nginx configuration (with AJAX)? |
I was imagining doing this by creating a new ocfweb API function that returns the list of desktops (just like how we have an API function for returning lab hours). However, I suppose baking this information into the Docker container could work, in that case we wouldn't use AJAX but instead probably generate a Javascript file that assigns the Either way, we would first need to make a YAML config file in https://github.com/ocf/etc and then make ocflib functions to parse the file, just like what we do for lab hours. |
So every time there is a desktop change we need to re-build the container for lab map? |
If we implemented it that way then yes |
This is mentioned in the comments for updateMap but I still think there should be also be an api function that returns all available public desktops (the list of all desktops minus the ones we mark as not being publicly available minus the ones currently in use). This solves the problem we're discussing here and also simplifies updateMap. |
Right now the positions of the machines are hardcoded in the typescript file.
It would be nice if we could read the mapping off some other file and maybe also have a way of indicating if a machine is out of service there.
I don't know how we do it now but @dongkyunc used to manually edit the page if a machine was broken.
The text was updated successfully, but these errors were encountered: